cmd/crossplane/xpkg/annotations.go (1)

30-40: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Consider validating that annotation keys are non-empty.

The current implementation would accept an annotation like =value (empty key), which could cause confusing errors later when pushing to the registry. Adding a simple validation would provide users with a clearer, earlier error message.

🛡️ Suggested validation

 func parseAnnotations(kvs []string) (map[string]string, error) {
 	anns := make(map[string]string, len(kvs))
 	for _, kv := range kvs {
 		k, v, ok := strings.Cut(kv, "=")
 		if !ok {
 			return nil, errors.Errorf("invalid annotation %q: must be in key=value format", kv)
 		}
+		if k == "" {
+			return nil, errors.Errorf("invalid annotation %q: key cannot be empty", kv)
+		}
 		anns[k] = v
 	}
 	return anns, nil
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/crossplane/xpkg/annotations.go` around lines 30 - 40, The
parseAnnotations function accepts "k=v" pairs but doesn't reject empty keys
(e.g., "=value"); update parseAnnotations to validate that the extracted key
(variable k from strings.Cut on each kv) is non-empty and, if empty, return a
clear formatted error (similar to the existing errors.Errorf) indicating the
annotation has an empty key; ensure this check happens after the strings.Cut ok
check and before assigning into anns so no empty-key entries are inserted.